Repository navigation
Make packet tests more configurable - #423
Draft
cfzimmerman wants to merge 4 commits into
Draft
cfzimmerman wants to merge 4 commits into
cfzimmerman wants to merge 4 commits into
Conversation
cfzimmerman
commented
Nov 10, 2026
Comment on lines
+643
to
+649
| let Ok(packet) = packet::Packet::parse(&data).inspect_err(|e| { | ||
| eprintln!( | ||
| "Test harness drop, packet could not be parsed: {e:?}" | ||
| ) | ||
| }) else { | ||
| continue; | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
We previously panicked on irrational packets. For example, with an IPv4 IHL < 5. But the harness should support testing such packets because we need to verify how sidecar handles them.
cfzimmerman
force-pushed
the
cory/test-tlc
branch
from
November 11, 2026 01:16
c753790 to
568a67e
Compare
Should be backward compatible with no change in product behavior. Just an extra parsing feature.
cfzimmerman
force-pushed
the
cory/test-tlc
branch
from
November 11, 2026 01:52
568a67e to
b323a7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a loosely focused blob of test changes mostly in preparation for testing other PRs currently in the oven.
The swadm fix is totally unrelated and was inspired by a network channel question yesterday.