Repository navigation
[mcast, p4] decap sidecar on mcast from the userspace service port - #421
Closed
zeeshanlakhani wants to merge 1 commit into
Closed
zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
Multicast coming through from the switch zone heads back through the service port (with a sidecar header), but it only goes through `Services` when it's an IPv6 link-local destined packet. Other multicast traffic went through to mcast ingress with the sidecar header still attached, which meant that replicas (and NAT'd encaps) would be forwarded, malformed for downstream receivers. Ry's review on oxidecomputer/sidecar-lite#181 drove this work, which now matches sidecar-lite's `decap_sidecar()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multicast coming through from the switch zone heads back through the service port (with a sidecar header), but it only goes through
Serviceswhen it's an IPv6 link-local destined packet.Other multicast traffic went through to mcast ingress with the sidecar header still attached, which meant that replicas (and NAT'd encaps) would be forwarded, malformed for downstream receivers.
Ry's review on oxidecomputer/sidecar-lite#181 drove this work, which now matches sidecar-lite's
decap_sidecar().