Impl Diffable for NonZero with 'leaf!'#68
Merged
andrewjstone merged 2 commits intooxidecomputer:mainfrom Jun 18, 2025
Merged
Conversation
SamusAranX
pushed a commit
to AdmitCheck/daft-serialize
that referenced
this pull request
Nov 17, 2025
I noticed that `std::num::NonZero<T>` didn't impl `Diffable`, which I
would like to have for a project I'm working on. This simply uses the
`leaf!{}` macro to implement `Diffable` for each of the `NonZero*`
types.
I would have liked to do `impl<T: Diffable> Diffable for NonZero<T>` but
that requires us to add the `T: NonZeroablePrimitive` bound to the impl
(since that is a bound on the `NonZero` type itself), but we can't do
that since that trait isn't stable yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that
std::num::NonZero<T>didn't implDiffable, which I would like to have for a project I'm working on. This simply uses theleaf!{}macro to implementDiffablefor each of theNonZero*types.I would have liked to do
impl<T: Diffable> Diffable for NonZero<T>but that requires us to add theT: NonZeroablePrimitivebound to the impl (since that is a bound on theNonZerotype itself), but we can't do that since that trait isn't stable yet.