Skip to content

Conversation

@Victorcorcos
Copy link
Contributor

@Victorcorcos Victorcorcos commented Aug 28, 2025

Summary

  • Necessary to make it work -> 🎯 Phase 2: Complete Equations-Parser WebAssembly Integration parsec-web#2
  • Remove std::binary_function<TString, TString, bool> inheritance from SortByLength struct in parser/suSortPred.h
  • Fixes C++17 compatibility issue where std::binary_function was removed from the standard
  • Enables WebAssembly compilation which requires modern C++ standards
  • Updates README.md with a muuuch better version of it

Details

The std::binary_function base class was deprecated in C++11 and removed in C++17. The SortByLength functor doesn't need this inheritance as it already provides the required operator() method. This change maintains full functionality while ensuring compatibility with C++17 and later standards, which is necessary for WebAssembly compilation.

Test plan

  • Verify compilation succeeds with C++17
  • Confirm WebAssembly build works
  • Ensure existing functionality remains unchanged

…ations-parser library: binary_function -> Enable WebAssembly on it
@Victorcorcos Victorcorcos self-assigned this Aug 28, 2025
@Victorcorcos Victorcorcos added the enhancement New feature or request label Aug 28, 2025
@Victorcorcos Victorcorcos requested review from tiagogoncalves and removed request for niltonvasques August 28, 2025 07:56
@niltonvasques niltonvasques merged commit 3a79bde into oxeanbits:master Sep 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants