Format splices like prefix operators#147
Open
jbachurski wants to merge 1 commit into
Open
Conversation
jbachurski
force-pushed
the
jbachurski/splices-are-like-prefix-operators
branch
from
June 24, 2026 11:21
f1ebd0c to
8311859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now there were a few bugs with the formatting of splices as prefix operators, corresponding to the tests added in this PR:
!($x)->!$x, which broke AST re-parsing and crashed ocamlformat.In contrast to other prefix operators, splices have no unapplied
( $ )form, so that doesn't require work.I figured the easiest way to fix these is to move splices to use the same formatting as prefix operators. It might be cleaner to move
Pexp_spliceto literally be a case ofPexp_prefix, but that might be unnecessarily complicated.