Skip to content

feat: add focus-visible styles to home page buttons and code blocks. #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 3 commits into from
May 8, 2026
+10 −0
Merged

feat: add focus-visible styles to home page buttons and code blocks. #1069

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
541041a
feat: add focus-visible styles to home page buttons
claude Apr 25, 2026
022e6d2
feat: add focus-visible outline to code-group tabs
claude Apr 25, 2026
4089826
refactor: move code-group focus outline to wrapper element
claude Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .vitepress/theme/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@
--color-brand: #0d6a73;
}

.button:focus-visible {
outline: 2px solid var(--color-brand);
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new .button:focus-visible rule uses var(--color-brand), but that CSS variable is only defined under :root[data-variant="oxc"] selectors. If data-variant is ever missing/changed (or this CSS is reused for a different variant), the outline declaration becomes invalid and focus styles disappear. Consider switching to the already-used VitePress brand token (--vp-c-brand-1) or adding a fallback like var(--color-brand, var(--vp-c-brand-1)) to keep focus indicators reliable and consistent with other components (e.g. RulesTable.vue).

Suggested change
outline: 2px solid var(--color-brand);
outline: 2px solid var(--color-brand, var(--vp-c-brand-1));

Copilot uses AI. Check for mistakes.
outline-offset: 2px;
}

.vp-code-group:has(.tabs input:focus-visible) {
outline: 2px solid var(--color-brand);
outline-offset: 2px;
}

/* Override unusual GitHub avatars */
.VPTeamMembersItem {
--member-item-avatar-size-small: 64px;
Expand Down