Skip to content

test: expect the UpdateCertificateStore repair step - #41965

Merged
oc-tmueller merged 2 commits into
masterfrom
test/repair-steps-count
Nov 3, 2026
Merged

oc-tmueller merged 2 commits into
masterfrom
test/repair-steps-count

Conversation

@oc-tmueller

Copy link
Copy Markdown
Contributor

#41910 registered UpdateCertificateStore as a repair step, so occ maintenance:repair --list now reports 17 steps. cliMain/maintenance.feature:9 still asserts "Found 16 repair steps". The full CLI acceptance suite doesn't run on PRs, so #41910 merged green, and 11.1.0 shipped with the stale assertion. It surfaced in owncloud-docker/server#753, the first full CLI run against 11.1.0:

The command output did not contain the expected text on stdout 'Found 16 repair steps'
The command output on stdout was:
Found 17 repair steps
...
OC\Repair\UpdateCertificateStore -> Update certificate stores with new root certificates
  • Expect 17 steps and list OC\Repair\UpdateCertificateStore.
  • Skip the scenario on 10.x and 11.0, which don't register the step and still list 16. @skipOnOcV10 covers the 10.12/10.13 tags it replaces.

Test-only, so there's no changelog entry.

🤖 Generated with Claude Code

oc-tmueller and others added 2 commits November 3, 2026 13:41
#41910 registered UpdateCertificateStore as a repair step, so
`occ maintenance:repair --list` now reports 17 steps. The full CLI
acceptance suite does not run on PRs, so cliMain/maintenance.feature:9
kept asserting 16 and fails against 11.1.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
UpdateCertificateStore is only registered from 11.1 on, so 10.x and 11.0
still list 16 repair steps. @skipOnOcV10 covers the 10.12/10.13 tags it
replaces.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
@oc-tmueller
oc-tmueller requested a review from a team as a code owner November 3, 2026 12:43
oc-tmueller added a commit to owncloud-docker/server that referenced this pull request Nov 3, 2026
11.1.0 registers UpdateCertificateStore as a 17th repair step, but its
own cliMain/maintenance.feature:9 still asserts 16. owncloud/core#41965
fixes the test; the 11.1.0 QA tarball keeps the stale one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
@oc-tmueller
oc-tmueller merged commit 9e3033e into master Nov 3, 2026
37 checks passed
@oc-tmueller
oc-tmueller deleted the test/repair-steps-count branch November 3, 2026 14:04
oc-tmueller added a commit to owncloud-docker/server that referenced this pull request Nov 3, 2026
…ll (#753)

* feat(server): update 11.0.1 to 11.1.0 image from GitHub release tarball

Build the 11.x image from the owncloud-complete-20261103 bundle on the
v11.1.0 release and publish it as 11.1.0, 11.1 and 11. The 11.0 tag stays
on 11.0.1. Move the line's .trivyignore and acceptance expected-failure
lists to the new version.

migrate_to_ocis v3.0.3 bundles rclone v1.75.2, which fixes CVE-2026-84445,
CVE-2026-78667, CVE-2026-78669 and CVE-2026-97031, so those entries are
not carried over. CVE-2026-111943 stays (rclone is still built with
go1.26.9). A local trivy 0.70.0 scan of the built image without the file
reports exactly CVE-2024-4367 and CVE-2026-111943; with it, nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>

* ci(trivy): expire the CVE-2026-111943 acceptance on 2026-11-30

Match the expiry of the same acceptance in owncloud/server-release and
owncloud/migrate_to_ocis#80, so the image gate does not keep suppressing
it after those lapse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>

* ci(acceptance): expect 11.1.0's stale repair-step count to fail

11.1.0 registers UpdateCertificateStore as a 17th repair step, but its
own cliMain/maintenance.feature:9 still asserts 16. owncloud/core#41965
fixes the test; the 11.1.0 QA tarball keeps the stale one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>

* ci(acceptance): list the stale repair-step scenario for smoke runs too

The CLI suite runs in full on PRs and pushes as well, against the smoke
list, which is where #753's failing job looked it up. Also say the core
fix is proposed, not merged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>

---------

Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants