Skip to content

feat: permalink on oCIS servers - #5022

Merged
joragua merged 9 commits into
masterfrom
feature/permalink_sharing_ng
Oct 21, 2026
Merged

joragua merged 9 commits into
masterfrom
feature/permalink_sharing_ng

Conversation

@joragua

@joragua joragua commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Related Issues

App: #4939

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Oct 16, 2026
@joragua joragua linked an issue Oct 16, 2026 that may be closed by this pull request
10 tasks done
@joragua
joragua force-pushed the feature/permalink_sharing_ng branch 5 times, most recently from 5964725 to a256dfd Compare October 19, 2026 11:43
@joragua
joragua marked this pull request as ready for review October 20, 2026 09:45
@joragua
joragua requested a review from a team as a code owner October 20, 2026 09:45
@joragua
joragua requested a review from jesmrec October 20, 2026 12:35

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, let's move to QA 🚀

@jesmrec
jesmrec self-requested a review October 20, 2026 12:44
jesmrec
jesmrec previously approved these changes Oct 20, 2026
@jesmrec

jesmrec commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

(1) [WONT FIX HERE]

In Kiteworks servers, the Share option is now available (it should not). We should prevent it, but, it could be done in the current PR, or together with #5008

What do you think?

@joragua

joragua commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

We can handle this in the issue you mentioned, along with the Share option in the top bar

@jesmrec

jesmrec commented Oct 21, 2026

Copy link
Copy Markdown
Member

Approved on my side!!

Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua requested a review from jesmrec October 21, 2026 09:53
@joragua
joragua merged commit 45c76e8 into master Oct 21, 2026
12 checks passed
@joragua
joragua deleted the feature/permalink_sharing_ng branch October 21, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Sharing NG: Permalink

2 participants