Skip to content

fix: guard bottom-nav against NPE when no account is set #5012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesmrec merged 4 commits into from
Oct 19, 2026
+9 −0
Merged

fix: guard bottom-nav against NPE when no account is set #5012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22dee14
fix: guard bottom-nav against NPE when no account is set (#4998)
ibrahim-iqbal Oct 12, 2026
0bbd3bf
chore: add calens file
ibrahim-iqbal Oct 14, 2026
f05c70d
refactor: inline the null-account guard, drop the AI-flavored comment
ibrahim-iqbal Oct 14, 2026
8f500b1
refactor: drop remaining AI-flavored doc comment on bottomBarNavigati…
ibrahim-iqbal Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/5012
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Guard bottom navigation against crash when no account is set

A null-account check has been added to the bottom navigation so it skips navigation instead of crashing.

https://github.com/owncloud/android/issues/4998
https://github.com/owncloud/android/pull/5012
3 changes: 3 additions & 0 deletions owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ abstract class DrawerActivity : ToolbarActivity() {
}

private fun bottomBarNavigationTo(menuItemId: Int, isCurrentOptionActive: Boolean) {
if (account == null) {
return
}
when (menuItemId) {
R.id.nav_all_files -> navigateToOption(FileListOption.ALL_FILES)
R.id.nav_spaces -> navigateToOption(FileListOption.SPACES_LIST)
Expand Down
Loading