Skip to content

[TECHNICAL] OCS sharing and space members refactor #4949

Description

@joragua

With the new implementation for OCIS shares listing (#4876), it's necessary to refactor all classes and methods related to the legacy sharing implementation to keep the codebase consistent.

OCS implementation → Use the Ocs prefix.
Graph API implementation → Use the Graph prefix (already done) ✅

Moreover, an additional check is needed in the XML files used for space members and shares to ensure that the ids are generic and consistent.

TODOs

  • Refactor OCS classes adding the Ocs prefix
  • Refactor XML files used for space members and shares
  • Move the adapter and the recycler view setup for roles in AddMemberFragment to onViewCreated method
  • Add a delay to the members search to avoid repetitive requests when user types quickly
  • Use extension functions to bind roles, date picker and other UI elements
  • Refactor the members filter to match the implementation in AddGraphShareFragment

TASKS

  • Research (if needed)
  • Create branch technical/ocs_sharing_and_members_refactor
  • Development tasks
    • Refactor OCS classes
    • Refactor XML files
    • Move the adapter and the recycler view to onViewCreated method
    • Add a delay to the members search
    • Use extension functions to bind roles, date picker, etc..
    • Refactor the members filter
    • Move roles and members adapter to the correct domain folder
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch technical/ocs_sharing_and_members_refactor into master

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions