Skip to content

[BUG] Sharing badges in oC10 are not refreshing #4938

Open

Description

@jesmrec

Steps to reproduce

  1. Open an oC10 account
  2. In web, share any folder (not file) with other user or by link (or remove them if they already exist)
  3. In app, pull to refresh

Actual behaviour

Badges are not refreshed. By browsing into the shared folder and browsing back, badges are refreshed

Expected behaviour

Pull to refresh action should update the badges

Reproduced with ownCloud 10.16.3 (stable)

Activity

  1. added this to the Backlog milestone on Jul 24, 2026
  2. modified the milestones: Backlog, 4.9 - Current on Oct 9, 2026
  3. mvanhorn commented on Oct 12, 2026

    @mvanhorn
    Contributor

    Folder refresh writes a child back only when its etag differs from the local row. ownCloud 10 leaves the etag unchanged when only share metadata changes, so a new sharedByLink value, sharedWithSharee value, or permissions value is dropped.

    When the etag still matches but sharedByLink, permissions, or the boolean sharedWithSharee value differ (null and false count as equal), that child is added to the files saved for the folder.

    #5013

  4. joragua commented on Oct 13, 2026

    @joragua
    Member

    Hi @mvanhorn! Thanks for your contribution here! 🙌🏻

    Just an additional comment about this issue. The bug is also reproducible on oCIS servers. Did you make changes to the code for both backends or only for oC10? @jesmrec, are the steps the same for oCIS?

  5. jesmrec commented on Oct 14, 2026

    @jesmrec
    MemberAuthor

    @joragua @mvanhorn same steps

  6. mvanhorn commented on Oct 14, 2026

    @mvanhorn
    Contributor

    @joragua The change in #5013 isn't backend-specific. It's in OCFileRepository.refreshFolder, which runs for both oC10 and oCIS (oCIS just passes a space WebDAV URL), and the badge fields come from the same oc:share-types parsing in RemoteFile for both. The new branch writes a child back whenever its etag matches the local row but sharedByLink, sharedWithSharee or permissions differ, with no server check.

    What I can't tell from the code is why oCIS shows the bug. If oCIS also keeps the etag unchanged when only sharing changes, this branch covers it. If oCIS does change the etag, the existing etag branch already saves that child, and the cause on oCIS would be somewhere else. I haven't tried it against either server, so a pull-to-refresh check on oCIS with @jesmrec's steps would settle it. If it does cover both, the changelog entry and the code comment should drop the oC10-only wording, and I can update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions