Repository navigation
ci: balance acceptance slices by measured suite duration - #754
Merged
Merged
Conversation
run.sh --part splits the sorted suite list by count, so one part could run 55 minutes while its sibling finished in 14. Pack the suites into slices of about equal duration instead, by the minutes each took in recent runs, and run each slice with run.sh --suites. Also cancel a pull request's superseded runs: they compete for the organization's 20 concurrent runners and queued later jobs for up to two hours. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
More slices than suites left some empty, and run.sh --suites "" runs every suite of the type. The cli suites always run in full, so weigh them by the full column in smoke runs too, as the table's header says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
Several suites of 0 minutes went to the same empty slice and left another one without any. Break ties by the number of suites in a slice. Weigh the cli suites by the longer of both columns, as the table records the longest time seen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance runs on pushes and PRs take about an hour; weekly and manual full runs take 3–4 hours. Two causes:
run.sh --partsplits the sorted suite list by count. In the smoke run 41643543217,10.16.7 cli 2/2ran 55 min (cliLocalStorage + cliMain + cliProvisioning) whilecli 1/2took 14. Full-run API parts ran from 30 to 118 min.Changes
.github/acceptance/suite-minutes.tsv: minutes per suite, the longest seen in recent 10.16.x / 11.0.1 / 11.1.0 runs..github/acceptance/plan-slices.sh: packs the suites into slices of about equal duration (longest first, each into the least-loaded slice). The plan job takes the suite list from the checksum-verified -qa tarball, and each slice runs withrun.sh --suites(supported by both 10.16.7 and 11.1.0).main.yml: a new push to a PR cancels that PR's older run. Runs on master, tags, the schedule and manual runs each get their own concurrency group, so they are never cancelled and never wait for each other.Expected effect
Predicted from the table, not yet measured:
Full runs stay bounded by the 20-runner cap (~1,600 runner-minutes).
The table needs refreshing when the suites change a lot. A suite it doesn't know only costs some balance, not coverage.
🤖 Generated with Claude Code