Repository navigation
fix: 数字と離れた英字を単位読みしない - #32
Merged
Merged
Conversation
空白を読み飛ばすと、離れた数字が英字の直前のトークンになるため、 階や部屋の英字記号を単位として読んでいた。 入力のバイト位置が連続する場合だけ単位読みを付ける。 既知語・未知語、全角英字、空白類と offset の回帰テストを追加する。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
数字と英字の間に空白があるとき、
3 F会議室が「ファラド」と読まれていました。数字のendと英字のstartが一致する場合だけ単位読みを付け、空白・タブ・改行で離れた F/A/W を綴り読みへ戻します。100 km・3 GB・5 Vも綴り読みになります。空白のない単位と、3文字以上の既知語にあるカタカナ読みの優先順位は維持します。設計・差分レビューとも妥当と確認し、指摘のあった辞書読みの例外を文書に明記しました。検証:
make ciと同等の format・workspace clippy/test・3 feature 構成の clippy/test が通過。Closes #29