Repository navigation
fix: Maven Central の正本から版と公開日を取得する - #18
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Search API の古い索引が新しい版を落とし、更新候補を latest と誤表示していた。 リポジトリの metadata から全版を取得し、採用候補の POM の公開日を確認してから age を判定する。完全一致の現在版が無い場合も取得失敗として示す。
owayo
force-pushed
the
fix/issue-16-maven-metadata-versions
branch
from
October 9, 2026 00:37
0936142 to
04deecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Maven Central Search API の索引が遅れている場合、新しい版を見落としていました。版一覧をリポジトリの
maven-metadata.xmlから取得し、更新候補の公開日を POM のLast-Modifiedで確認します。原因
検索索引の版一覧とタイムスタンプを正本としていたため、索引に載らない版は更新判定に入らず、表示日付も実際の公開日とずれていました。
変更内容
設計判断
判定器は既存の同期 API を維持し、レジストリアダプタの遅延日付取得を判定前に実行します。候補が新しすぎる場合は次候補へ進みます。全バージョンへの HEAD は行いません。
検証
make ci: passokhttpの5.4.0 → 5.5.0を実際のリポジトリに対する dry-run で確認Closes #16