Repository navigation
fix: Goのinstallで本体チェックサムと間接依存を揃える - #15
Merged
Merged
Conversation
引数なしのgo mod downloadはGo 1.17以降でモジュール本体のハッシュを go.sumへ記録せず、更新直後のreadonly buildが失敗していた。 go mod tidyでgo.modとgo.sumをソースに合わせて同期する。 ローカルのGo proxyを使った回帰テストで旧処理の失敗、新しい間接依存と 本体ハッシュの追加、readonly build/testの成功を検証する。 英語と日本語の文書に依存整理とvendorの更新手順を記載する。
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Goプロジェクトで
depup --installの後にgo buildがmissing go.sum entryで失敗する問題を修正します。Goのinstallをgo mod tidyに変更し、ソースに必要なgo.modとgo.sumを揃えます。Go 1.17以降、引数なしの
go mod downloadはモジュール本体のハッシュを保存しません。download allでハッシュだけを追加しても、新版が必要とする間接依存のrequireが不足し得るため、tidyで両方を同期します。tidyによる未使用依存の削除、ディレクティブの変更、vendorの更新手順は英語・日本語の文書に記載しました。検証
go build -mod=readonly ./...とgo test -mod=readonly ./...が成功。make ci: fmt-check / clippy / 全テスト。Closes #14