Skip to content

fix: classify untyped array count changes by element shape - #46

Merged
owayo merged 1 commit into
mainfrom
fix/issue-45-untyped-array-values
Oct 9, 2026
Merged

owayo merged 1 commit into
mainfrom
fix/issue-45-untyped-array-values

Conversation

@owayo

@owayo owayo commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Summary

Count-only changes to an exported, untyped array were reported as blocking API modifications even when its inferred element types stayed the same. Compare distinct widened element shapes for static arrays and report these edits as api.const_value with informational impact.

Keep empty-array transitions, removed element shapes, and as const tuple changes blocking.

Verification

  • Added unit and CLI regression cases for JavaScript, TypeScript, and TSX, including blocking controls.
  • The new CLI regression failed before the fix and passed after it.
  • cargo test, make check, cargo build --release, and release review --git passed.
  • A release-binary reproduction now exits 0 with api.const_value and informational impact.

Closes #45

The ordered array contract treated count-only edits as API modifications even when the inferred element types stayed the same. Compare distinct widened element shapes for static arrays, while preserving blocking changes for empty arrays, removed element shapes, and const assertions.

Regression tests: untyped_arrays_compare_distinct_widened_element_shapes, static_const_values_untyped_array_count_changes_follow_element_shapes, static_const_values_unsafe_changes_keep_blocking_api_mod
Issue: #45
@coderabbitai

coderabbitai Bot commented Oct 9, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8cd982f9-e29d-48be-b903-dfe93ddeb43c
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@owayo
owayo merged commit f57f81e into main Oct 9, 2026
9 checks passed
@owayo
owayo deleted the fix/issue-45-untyped-array-values branch October 9, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant