Repository navigation
fix: classify untyped array count changes by element shape - #46
Merged
Merged
Conversation
The ordered array contract treated count-only edits as API modifications even when the inferred element types stayed the same. Compare distinct widened element shapes for static arrays, while preserving blocking changes for empty arrays, removed element shapes, and const assertions. Regression tests: untyped_arrays_compare_distinct_widened_element_shapes, static_const_values_untyped_array_count_changes_follow_element_shapes, static_const_values_unsafe_changes_keep_blocking_api_mod Issue: #45
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Count-only changes to an exported, untyped array were reported as blocking API modifications even when its inferred element types stayed the same. Compare distinct widened element shapes for static arrays and report these edits as
api.const_valuewith informational impact.Keep empty-array transitions, removed element shapes, and
as consttuple changes blocking.Verification
cargo test,make check,cargo build --release, and releasereview --gitpassed.api.const_valueand informational impact.Closes #45