Repository navigation
fix: Swift の宣言名を refs で定義として分類する - #44
Merged
Merged
Conversation
Swift のプロパティ、型別名、列挙子、protocol 要件の名前が参照として数えられていた。 宣言の name フィールドと、プロパティの pattern 内の束縛位置を判定する。 タプルのラベル、型注釈、初期化子の参照は維持する。 回帰テスト: refs_swift_declarations_are_definitions_without_reclassifying_uses Issue: #42
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Swift の
let/var、型別名、列挙子、protocol 要件の宣言名をrefsでdefとして返すようにしました。原因と修正
プロパティ名は宣言ノード直下ではなく
nameのpattern内にあるため、既存の定義判定から漏れていました。束縛位置をたどる判定を追加し、複数宣言とタプル分解を扱います。列挙子の複数のnameもすべて判定します。タプルのラベル、型注釈、初期化子、使用箇所は
refのままです。検証
swiftc -typecheck tests/fixtures/swift_declaration_refs.swiftcargo testmake checkcargo build --releaseastro-sight impact --dir . --gitastro-sight review --dir . --gitCloses #42