Repository navigation
fix: Swift の空タプルを式とパターンとして解析する - #43
Merged
Merged
Conversation
同梱の Swift 文法はタプルの要素を必須としていたため、値やパターンの 空タプルに MISSING ノードや ERROR ノードが生じていた。 両方の規則で要素を省略可能にし、生成パーサーを更新する。 回帰テスト: swift_empty_tuple_cli_parses_values_and_patterns_without_diagnostics Issue: #41
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
有効な Swift コードで
()を値やパターンとして使うと、symbolsとastが構文エラーを報告する問題を修正しました。原因
同梱の Swift 文法で
tuple_expressionと_tuple_patternが要素を 1 個以上要求していました。変更内容
tuple_expression.valueが省略可能になる node-types を反映検証
swiftc -typecheck tests/fixtures/swift_empty_tuple.swift: passcargo test: passmake check: passcargo build --release: passtarget/release/astro-sight review --dir . --git: 追加検出なしCloses #41