Correct spotlight attenuation angle calculation#2250
Open
ada-tv wants to merge 1 commit into
Open
Conversation
ada-tv
added
needs CR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The part of #1481 that doesn't need a new light property
Master
Aliased and difficult to tune since spotlights were calculated as 180° flat lights with a hard angular cutoff
This PR
Smooth and easier to tune, spotlight falloff angle is calculated correctly
Inner angle is currently hardcoded to 98% of the outer angle
Tried my best to match the existing exponent behavior, though the way it works is a bit weird and there are cases where the spotlight just completely disappears (high exponents with low angles)