Do warnings as errors always on Linux, not just on gcc 11

[daleglass]

I don't see the reason to restrict warnings as errors to GCC 11 specifically.

New compilers catch more mistakes. The point of warnings as errors is not to add more bad stuff to start with, and to fix errors that were hiding until the compiler got better at catching them.

After PR #2184 we should be back to a fully clean build on GCC 15.2.1.

[ksuprynowicz]

Maybe we could do it only for GH actions builds?
Many end users build form source, and having warnings always fixed is impossible since people on cutting edge distributions get new compilers way before we do.

[ksuprynowicz]

Or maybe we could do it up to a given, known version so that it doesn't break for end users before we have chance to fix it?

[ada-tv]

-Werror can be a hassle when debugging from source too, so my preference would be for only doing it on CI

[ksuprynowicz]

I'd also like having it only on CI

[daleglass]

-Werror can be a hassle when debugging from source too, so my preference would be for only doing it on CI

My approach is to fix warnings first, debug later if still broken. Warnings are a good sign something isn't quite right.

I'd also like having it only on CI

CI has an old compiler though, it catches less stuff. I want the pickier the better, because the code is crashing as it is, so obviously something isn't quite right still.

Or maybe we could do it up to a given, known version so that it doesn't break for end users before we have chance to fix it?

Alright, we can bump it to a GCC 15.2.1 because I tested with that. After PR #2184 it'll be clean.

[ksuprynowicz]

Alright, we can bump it to a GCC 15.2.1 because I tested with that. After PR #2184 it'll be clean.

I think doing it this way is a good idea. Then when GCC 16 comes out with new warnings we will have time to fix them.