Allow UDP packets to be fragmented#2155
Draft
Hanicef wants to merge 1 commit intooverte-org:masterfrom
Draft
Conversation
Contributor
|
This is likely to be more trouble than it's worth. IP fragmentation results in fragments that lack the TCP/UDP headers. So a fragment doesn't have any port numbers, which firewalls really like to have. I'm going to guess that this will cause some people a whole lot of trouble. At the very least, implement it as a command-line option, so that people have to opt into it explicitly while troubleshooting. That way it's not going to break things for anyone that currently has no problems. |
Member
|
I think this should be disabled by default and enabled by a command line parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experment to allow Overte to fragment packets, as it was explicitly disabling it before. Since it's known that some packets do go beyond MTU limits, those packets are guaranteed to be dropped in transit, so this might be a workaround for now until the packet sizes are fixed.
(cc @zedwick)