Skip to content

Use int handles for script timers instead of QTimer*#2104

Open
ada-tv wants to merge 1 commit intooverte-org:masterfrom
ada-tv:fix/script-timer-handles
Open

Use int handles for script timers instead of QTimer*#2104
ada-tv wants to merge 1 commit intooverte-org:masterfrom
ada-tv:fix/script-timer-handles

Conversation

@ada-tv
Copy link
Copy Markdown
Collaborator

@ada-tv ada-tv commented Mar 8, 2026

Script.setTimeout and Script.setInterval now have mostly-standard JS timer return values

The timer handle map is per-context, so calling clearTimeout on a handle exposed by a module won't work properly.

Should fix #2098

@ada-tv ada-tv added bug Something isn't working needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Mar 8, 2026
ksuprynowicz
ksuprynowicz approved these changes Mar 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good :)

@ksuprynowicz ksuprynowicz added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ksuprynowicz ksuprynowicz ksuprynowicz approved these changes

Assignees

No one assigned

Labels

bug Something isn't working CR approved This pull request has been successfully code reviewed needs QA This pull request needs to be tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setTimeout handles are corrupted when accessed by closure capture rather than direct variable binding

2 participants

@ada-tv @ksuprynowicz