Skip to content

Remove lua54 from build.js (lua53 deprecation)#277

Open
GamingLuke1337 wants to merge 1 commit into
overextended:mainfrom
GamingLuke1337:patch-1
Open

Remove lua54 from build.js (lua53 deprecation)#277
GamingLuke1337 wants to merge 1 commit into
overextended:mainfrom
GamingLuke1337:patch-1

Conversation

@GamingLuke1337
Copy link
Copy Markdown

No description provided.

Signed-off-by: Lukas Döring <lksdrng@icloud.com>
Copilot AI review requested due to automatic review settings May 2, 2026 09:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated fxmanifest.lua to stop explicitly enabling lua54, aligning the manifest output with the intended Lua runtime configuration going forward.

Changes:

  • Removed the lua54 'yes' line from the fxmanifest.lua template generated by build.js.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SkylarPlayz348
Copy link
Copy Markdown

@darksaid98
Copy link
Copy Markdown
Contributor

The change looks good, but I'd like to point out that it might potentially be prudent to bump the minimum server artifact (to the one where the lua54 var became deprecated) if this were accepted.

Otherwise, there's a risk people put modern builds of Oxmysql on servers that implicitly run the resource using Lua 5.3, no?

All comes down to what Linda wants:

  • Should modern builds of Oxmysql be more limited/scoped to supporting somewhat modern artifacts
  • Or should artifact backwards compat support be prioritized

I'm all for innovation/staying up-to-date, but IMO unless the lua54 flag is causing warnings or any such nonsense, it seems easiest to just keep it for backwards compat. At least in the short term.

@SkylarPlayz348
Copy link
Copy Markdown

Those servers running with 5.3 support need to be updated as those servers are not supported by the client.

@GamingLuke1337
Copy link
Copy Markdown
Author

As in the announcement (https://forum.cfx.re/t/removal-of-lua-5-3-support/5335232) Lua 5.3 was removed entirely, and even old server artifacts can't use them since the client doesn't support it anymore.

In case anyone might be running an outdated server and client though, that could be an issue. But that setup would not be supported by any developer in FiveM or CFX

@SkylarPlayz348
Copy link
Copy Markdown

SkylarPlayz348 commented May 5, 2026

The only way to run an outdated client is to never go online and run only local servers. This breaks with the new requirement of rockstar launcher.(I have tried going on fivem without internet and it said it could not authenticate or something) So right now you cannot "run an outdated client"

@darksaid98
Copy link
Copy Markdown
Contributor

As in the announcement (forum.cfx.re/t/removal-of-lua-5-3-support/5335232) Lua 5.3 was removed entirely, and even old server artifacts can't use them since the client doesn't support it anymore.

In case anyone might be running an outdated server and client though, that could be an issue. But that setup would not be supported by any developer in FiveM or CFX

In that case, I don't see any reason not to remove this field. Still might be prudent to bump the articat requirement though no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants