Remove lua54 from build.js (lua53 deprecation)#277
Conversation
Signed-off-by: Lukas Döring <lksdrng@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the generated fxmanifest.lua to stop explicitly enabling lua54, aligning the manifest output with the intended Lua runtime configuration going forward.
Changes:
- Removed the
lua54 'yes'line from thefxmanifest.luatemplate generated bybuild.js.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The change looks good, but I'd like to point out that it might potentially be prudent to bump the minimum server artifact (to the one where the Otherwise, there's a risk people put modern builds of Oxmysql on servers that implicitly run the resource using Lua 5.3, no? All comes down to what Linda wants:
I'm all for innovation/staying up-to-date, but IMO unless the |
|
Those servers running with 5.3 support need to be updated as those servers are not supported by the client. |
|
As in the announcement (https://forum.cfx.re/t/removal-of-lua-5-3-support/5335232) Lua 5.3 was removed entirely, and even old server artifacts can't use them since the client doesn't support it anymore. In case anyone might be running an outdated server and client though, that could be an issue. But that setup would not be supported by any developer in FiveM or CFX |
|
The only way to run an outdated client is to never go online and run only local servers. This breaks with the new requirement of rockstar launcher.(I have tried going on fivem without internet and it said it could not authenticate or something) So right now you cannot "run an outdated client" |
In that case, I don't see any reason not to remove this field. Still might be prudent to bump the articat requirement though no? |
No description provided.