fix(alerts): working notification-settings deep link + muted visibility in lists#24
Merged
Merged
Conversation
…ty in lists - The 'Open Windows notification settings' button was dead: the shell plugin's open() URL validator only permits http(s)/mailto/tel, so the ms-settings: scheme was silently rejected. Add an open_notification_settings backend command that opens it via the OS opener (explorer on Windows, mirroring open_log_directory); banner now invokes it. - Make muted devices obvious in the ASIC and OverMobile list views: amber tint on the card and table row, and the status badge shows 'Muted' instead of the normal status. Selection highlight still takes precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pieces of polish on the v1.6 mute/notification features (found during runtime verification).
1. Dead 'Open Windows notification settings' button
The button used the shell plugin's
open(), whose default URL validator only permitshttp(s)/mailto/tel— so thems-settings:notificationsscheme was silently rejected (clicking did nothing on Windows 11).open_notification_settingsbackend command that opens the OS notification settings via the OS opener (explorer ms-settings:notificationson Windows, mirroring the existingopen_log_directorypattern; best-effortopen/gnome-control-centeron macOS/Linux).NotificationBannernowinvokes it (with error logging) instead of the blocked shell open.2. Muted devices weren't obvious in the lists
In the ASIC (
MinerList) and OverMobile (MobileMinerList) card and table views, a muted device now:Muted state is read via
get_muted_deviceson mount and re-fetched onfarm-state-updated. The selection highlight still takes precedence over the muted tint.Verification
cargo check✅ ·npx tsc --noEmit✅