Skip to content

Apply RFC 9457 standard-member rules to Problem payloads - #14

Merged
kdubb merged 1 commit into
mainfrom
codex/rfc9457-standard-members
Oct 28, 2026
Merged

kdubb merged 1 commit into
mainfrom
codex/rfc9457-standard-members

Conversation

@kdubb

@kdubb kdubb commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

ProblemPayload treats null and wrong JSON categories in type, title, status, detail, and instance as absent before Pydantic applies defaults and validation. A shared mapping normalizer also runs before registry and generated-union dispatch. Missing type resolves to about:blank; HTTP context supplies absent status and default about:blank titles. Serialization omits absent standard members and preserves nullable extensions.

The five standard wire names are reserved. Subclasses can specialize their constraints, requiredness, defaults, and serializers. Extension fields support normal Pydantic aliases and paths that do not claim reserved names. Rejecting standard-member aliases is Sunday API policy; the RFC specifies the wire format rather than Python property names. The migration notes document this contract.

Validation: 675 runtime tests passed with both locked and minimum dependencies; 33 compiler-backed Generator Problem tests passed across RAML, OpenAPI, AsyncAPI, and composed inputs. Ruff formatting/lint, mypy, and wheel/sdist validation passed. Regression coverage includes direct decoding, TypeAdapter, inheritance, unions, registry/HTTPX/Litestar integration, required JSON schemas, field presence, and nullable extensions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:05:14.627031Z 31ebc0e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f09dd2d5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
@greptile-apps

greptile-apps Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable defects were found.

Summary

The PR applies RFC 9457 standard-member rules before payload validation.

  • Problem payloads ignore malformed standard values and use HTTP context for defaults.
  • Problem payloads keep RFC member names and omit null standard fields.

All six supplied previous threads are unnumbered. Current code addresses their reported causes through canonical wire names, preserved mapping copies, and native model validation. No duplicate comments are needed.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Problem mapping] --> B[Normalize standard members]
    B --> C[Registry selects problem type]
    C --> D[Add HTTP defaults]
    D --> E[Validate payload]
    E --> F[Serialize fields and extensions]
    F --> G[Omit null standard members]
Loading

Reviews (5) · Last reviewed commit: "Apply RFC 9457 standard-member rules to ..." · Reviewed by Greptile

Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70dedce12c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01a62b63f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved
Comment thread src/sunday/problems.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 937ec2cd8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/sunday/_problem_input.py Resolved
Comment thread src/sunday/problems.py Resolved
Normalize null and wrong JSON categories before native Pydantic validation and
Problem subtype dispatch. Apply about:blank and HTTP-context defaults, omit
absent standard members on encoding, and preserve extension values.

Reserve the five standard wire names, retain authored validation and serializer
behavior, and cover runtime and generated-client integration.
@kdubb
kdubb force-pushed the codex/rfc9457-standard-members branch from f4190a8 to 31ebc0e Compare October 28, 2026 03:03
@kdubb kdubb changed the title Normalize RFC 9457 standard members before Problem validation Apply RFC 9457 standard-member rules to Problem payloads Oct 28, 2026
@kdubb
kdubb merged commit 55933db into main Oct 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant