Repository navigation
Apply RFC 9457 standard-member rules to Problem payloads - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f09dd2d5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
[Medium impact] The PR appears safe to merge; no new actionable defects were found. SummaryThe PR applies RFC 9457 standard-member rules before payload validation.
All six supplied previous threads are unnumbered. Current code addresses their reported causes through canonical wire names, preserved mapping copies, and native model validation. No duplicate comments are needed. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Problem mapping] --> B[Normalize standard members]
B --> C[Registry selects problem type]
C --> D[Add HTTP defaults]
D --> E[Validate payload]
E --> F[Serialize fields and extensions]
F --> G[Omit null standard members]
Reviews (5) · Last reviewed commit: "Apply RFC 9457 standard-member rules to ..." · Reviewed by Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70dedce12c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01a62b63f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 937ec2cd8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Normalize null and wrong JSON categories before native Pydantic validation and Problem subtype dispatch. Apply about:blank and HTTP-context defaults, omit absent standard members on encoding, and preserve extension values. Reserve the five standard wire names, retain authored validation and serializer behavior, and cover runtime and generated-client integration.
f4190a8 to
31ebc0e
Compare
ProblemPayload treats null and wrong JSON categories in
type,title,status,detail, andinstanceas absent before Pydantic applies defaults and validation. A shared mapping normalizer also runs before registry and generated-union dispatch. Missing type resolves toabout:blank; HTTP context supplies absent status and defaultabout:blanktitles. Serialization omits absent standard members and preserves nullable extensions.The five standard wire names are reserved. Subclasses can specialize their constraints, requiredness, defaults, and serializers. Extension fields support normal Pydantic aliases and paths that do not claim reserved names. Rejecting standard-member aliases is Sunday API policy; the RFC specifies the wire format rather than Python property names. The migration notes document this contract.
Validation: 675 runtime tests passed with both locked and minimum dependencies; 33 compiler-backed Generator Problem tests passed across RAML, OpenAPI, AsyncAPI, and composed inputs. Ruff formatting/lint, mypy, and wheel/sdist validation passed. Regression coverage includes direct decoding, TypeAdapter, inheritance, unions, registry/HTTPX/Litestar integration, required JSON schemas, field presence, and nullable extensions.