fix(serialization): prevent PostProcess project-load crash - #776
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a project containing a
PostProcessconnection crashes withPort not found: input: the node declaresin, but both model and UI legacy converters normalize savedinlinks toinput. This also affects projects saved by the current application.Rename the PostProcess input to
inputto match the existing conversion and update its bundled port documentation. Extend the graph-editor loading regression test to cover bothinandinput, verify model/UI connections remain consistent without triggering computation, and verify save/reload preserves the connection.Validation:
Terrain_v002.hsd.git diff --checkpassed.CI follow-up: install
qtserialportalongside the existing Qt modules. The AppImage packager deploys Qt's NMEA positioning plugin, which requireslibQt6SerialPort.so.6; the missing library also breaks upstream dev. The updated workflow passes actionlint; AppImage validation is pending the new CI run.Fixes #775.