refactor(gui): move the Hesiod node proxy out of the model (step 3) - #772
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseNodecurrently supplies GNodeGUI’s proxy interface, pulling Qt into model headers and exposing GUI port directions to model code. This moves that interface intoHesiodNodeProxyin the GUI layer while preserving node/port IDs, captions, comments, tooltips and data access.Step 3 of #751; depends on #771. This branch includes step 2 until that PR merges. Review the step 3 change separately in commit 3a649cbb.
This removes the GUI dependency from these model headers. Existing model implementations still use Qt and application services; remaining settings/update paths are a follow-up step.
Validation on upstream
dev(f62c18c5): application build and model-header compilation passed; all 29 Qt checks passed.cmake --build build --target hesiod test_graph_editor -j 12 ctest --test-dir build -R '^graph_editor$' --output-on-failure