Gestionnaire de fichiers : étape 2#4204
Draft
arnaudlevy wants to merge 14 commits into
Draft
Conversation
SebouChu
reviewed
Jul 17, 2026
|
|
||
| def picker | ||
| @picker = Communication::File::Picker.new( | ||
| objects: @files, |
Member
There was a problem hiding this comment.
est-ce-qu'il faudrait pas simplement que les pickers se basent sur l'université en paramètre? je trouve que ça allège
Member
Author
There was a problem hiding this comment.
à la place de @files ? Je comprends pas.
Comment on lines
+62
to
+67
| if (xhr.readyState == 4 && xhr.status == 200) { | ||
| this.data = JSON.parse(xhr.responseText); | ||
| this.parameters = this.data.parameters; | ||
| this.pagination = this.data.pagination; | ||
| this.results = this.data.results; | ||
| } |
Member
There was a problem hiding this comment.
ça manque de la gestion d'erreurs
Comment on lines
+3
to
+4
| json.results do | ||
| json.list @picker.results do |file| |
Member
There was a problem hiding this comment.
pourquoi pas juste faire json.results @picker.results do |file|
Member
Author
There was a problem hiding this comment.
il va y avoir des paramètres liés à la grille des résultats
Member
Author
|
Tu as raison ! Mais à cette étape il faut vérifier l'archi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
https://developers.osuny.org/docs/admin/composants/picker/
Niveau d'incidence