Assert the dispute window clearly inside its boundary - #113
Merged
Merged
Conversation
The on-chain fallback test jumped to exactly the dispute deadline and expected the still-open revert, but a mined block's timestamp is the chain's own — anvil can land the follow-up transaction one second past the boundary, which flips the expectation. Assert clearly inside the window instead (deadline minus a minute); the exact-boundary semantics stay covered by the deterministic Python model. Fixes the flaky repository-baseline failure on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
repository-baselinefailure on main (fc8c6f6): the on-chain settlement exercise jumped to exactly the dispute deadline and expectedapplyDisputeFallbackto revert withDisputeWindowStillOpen— but the follow-up transaction is mined in a block whose timestamp is the chain's own choice, and anvil can land it one second past the boundary, which flips the expectation. Real chains never guarantee exact block times; the suite now asserts clearly inside the window (deadline minus a minute), while the exact-boundary semantics remain covered by the deterministic Python model test. Verified 4× green locally (the failure reproduced on main's CI).