Restore the cloud in the social preview icon - #74
Merged
Merged
Conversation
ImageMagick's internal SVG rasterizer silently drops elements carrying SVG filters, which removed the cloud path (feDropShadow) from the PDrive icon in both social-preview variants. Rasterize the icon with Librsvg, which renders the filter faithfully, declare librsvg2-bin in the check workflow, and regenerate both variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsvg-convert), which renders the filter faithfully, and declarelibrsvg2-binin the check workflow so the renderer exists in CI.Verification
make social-preview,make check-social-preview(byte-identical), fullmake checkgreen,git diff --checkclean.