api: Allow multiple NLRIs in single MpReachNLRIAttribute#1755
Closed
iwaseyusuke wants to merge 1 commit into
Closed
api: Allow multiple NLRIs in single MpReachNLRIAttribute#1755iwaseyusuke wants to merge 1 commit into
iwaseyusuke wants to merge 1 commit into
Conversation
Currently, api.UnmarshalPathAttributes() does not allow the multiple NLRIs in a single MpReachNLRIAttribute because when AddPath API supposes only single NLRI is composed. This assumption is equivalent to that "message Path" structure should have single NLRI for calling AddPath API. But to represent the received UPDATE messages from peers, a single MpReachNLRIAttribute can contain the multiple NLRIs. This patch fixes to allow the multiple NLRIs in a single MpReachNLRIAttribute and removes this constraint. Signed-off-by: IWASE Yusuke <iwase.yusuke0@gmail.com>
iwaseyusuke
deleted the
api-Allow_multiple_NLRIs_in_single_MpReachNLRIAttribute
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, api.UnmarshalPathAttributes() does not allow the multiple NLRIs in a single MpReachNLRIAttribute because when AddPath API supposes only single NLRI is composed. This assumption is equivalent to that "message Path" structure should have single NLRI for calling AddPath
API.
But to represent the received UPDATE messages from peers, a single MpReachNLRIAttribute can contain the multiple NLRIs.
This patch fixes to allow the multiple NLRIs in a single MpReachNLRIAttribute and removes this constraint.
Also this PR and #1754 will solve the CI errors on #1731