Skip to content

Close a small memory leak when stage initialization fails#49

Open
cottsay wants to merge 1 commit into
mainfrom
cottsay/stage-init-leak
Open

Close a small memory leak when stage initialization fails#49
cottsay wants to merge 1 commit into
mainfrom
cottsay/stage-init-leak

Conversation

@cottsay

@cottsay cottsay commented May 7, 2026

Copy link
Copy Markdown
Member

Ownership of cmd_ctx doesn't get transferred to ctx until 5 lines later, so we need to explicitly free it during failure handling here.

@cottsay cottsay requested a review from j-rivero May 7, 2026 18:08
@cottsay cottsay self-assigned this May 7, 2026
@cottsay cottsay added bug Something isn't working good first issue Good for newcomers labels May 7, 2026
@codecov-commenter

codecov-commenter commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.60%. Comparing base (488c204) to head (a32177c).

Files with missing lines Patch % Lines
src/createrepo-agent/command.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   54.64%   54.60%   -0.04%     
==========================================
  Files          22       22              
  Lines        2853     2855       +2     
  Branches      598      599       +1     
==========================================
  Hits         1559     1559              
- Misses        974      975       +1     
- Partials      320      321       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants