Repository navigation
pyosmium-up-to-date: Add option --user-agent - #328
Merged
Merged
Conversation
jocelynj
force-pushed
the
pyosmium-up-to-date-user-agent
branch
from
October 26, 2026 21:52
9a15b1c to
3acbe20
Compare
lonvia
reviewed
Oct 26, 2026
lonvia
left a comment
lonvia
left a comment
Member
There was a problem hiding this comment.
We can do that. Do you mind adding the same option to pyosmium-get-changes as well for symmetry?
Contributor
Author
|
No problem, I will do the change to pyosmium-get-changes too. Is there any documentation to update too? |
User-agent is then replaced by "pyosmium/{version} - VALUE".
jocelynj
force-pushed
the
pyosmium-up-to-date-user-agent
branch
from
October 26, 2026 22:36
3acbe20 to
f304f57
Compare
Member
|
The documentation is auto-generated from the argparser and testing this kind of stuff is a bit tricky. So this is good to go. Thanks. There should be another release with this change this year. It's waiting on the next libosmium release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new option doesn’t replace the whole User-Agent, to keep the pyosmium prefix, but I can change the code if you prefer to replace the whole field.