Remove three orphaned manager image definitions#2572
Merged
Conversation
The drift detector's image_orphan check flags nginx, registry, and
osism_netbox: the manager render emits <alias>_image for each, but no
role or manager playbook consumes {{ <alias>_image }}. All three are
genuine leftovers -- nginx's consumer (the netbox role's nginx proxy)
was removed in osism/ansible-collection-services#170, osism_netbox's in
#1775 (replaced by the generic osism_image), and registry never had a
consumer (metalbox runs a hardcoded library/registry:3, independent of
this pin).
Remove the release side of the cleanup: the nginx and registry pins from
latest/base.yml docker_images, and the osism_netbox, nginx, and registry
registry-path entries from etc/images.yml. netbox (a distinct, consumed
image) is left untouched. The matching render-template emits are removed
in osism/generics and osism/container-image-osism-ansible.
Resolves osism/issues#1405. Verified: image_orphan drops from 3 to 0.
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the
osism/issues#1405cleanup — remove three manager imagedefinitions that the render emits but nothing deploys (flagged by the
drift detector's
image_orphancheck:nginx,registry,osism_netbox).This is the release side:
latest/base.yml— drop thenginxandregistrydocker_imagespins.etc/images.yml— drop theosism_netbox,nginx,registryregistry-path entries.netbox(a distinct, consumed image) is left untouched. The matchingrender-template emits are removed in the two companion PRs (generics +
container-image-osism-ansible).
Verified:
image_orphandrops from 3 to 0.Part of osism/issues#1405.