Align os_distro schema values with Glance docs#1244
Merged
Conversation
Match the os_distro enum in the schema with the values documented at https://docs.openstack.org/glance/latest/admin/useful-image-properties: add the missing documented values (notably 'rocky', plus 'gentoo', 'mandrake', 'mandriva', 'mes', 'msdos', 'netbsd', 'netware', 'openbsd', 'opensolaris', 'sled') and drop the undocumented, unused 'clearlinux'. 'cirros' and 'talos' are kept because they are used by existing image definitions and have no official os_distro value. Now that 'rocky' is permitted, switch the Rocky Linux images from the 'centos' workaround to 'rocky'. Closes #1105 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns the
os_distroenum inetc/schema.yamlwith the values documented for the property in the OpenStack Glance docs.Schema (
etc/schema.yaml)rocky(the subject of Cannot setos_distrotorocky#1105), plusgentoo,mandrake,mandriva,mes,msdos,netbsd,netware,openbsd,opensolaris,sled.clearlinux— not documented and no longer used by any image definition.cirrosandtalos— both are used by existing image definitions (cirros.yml,talos.yml) and have no officialos_distrovalue. A comment documents this exception.Rocky Linux (
etc/images/rockylinux.yml)rockyis permitted, switched the Rocky 8 and Rocky 9 images from thecentosworkaround toos_distro: rocky. Note: this changes the resulting image tag fromos:centostoos:rocky.Verification
All 12 image definitions under
etc/images/validate cleanly against the updated schema withyamale.Closes #1105
🤖 Generated with Claude Code