kolla: drop orphaned image and enable vars for removed services#296
Merged
Conversation
Remove 11 complete `# role:` image-catalogue blocks from
all/002-images-kolla.yml, covering all 38 orphaned <svc>_image /
<svc>_tag variables the release repo's kolla_image_orphan drift check
reports: monasca (and every sub-image: agent, api, logstash, thresh,
notification, persister, grafana), rally, vmtp, kibana, zookeeper,
elasticsearch (and elasticsearch-curator), kafka, storm, panko, chrony,
and qdrouterd.
Every one of these services was removed from upstream kolla-ansible
well before the oldest OSISM-supported release (2024.1), confirmed by
kolla-ansible git history:
chrony 2021-05-17 Remove chrony role
rally, panko 2021-07-01 Remove rally and panko again
vmtp 2021-12-20 Drop vmtp
monasca-grafana 2022-03-21 Remove monasca-grafana
qdrouterd 2022-04-08 drop qdrouterd support
elasticsearch, kibana, curator 2022-09-09 Replace ElasticSearch and
Kibana with OpenSearch
monasca+deps, kafka, storm, 2023-10-02 Remove remnants of Monasca
zookeeper and deps
None of them is an OSISM-built image (each had an upstream role that was
retired, so none meets the "OSISM image with no upstream role" bar for
allowlisting), and none is consumed anywhere in OSISM -- the only
zookeeper reference is Zuul's separate zuul_zookeeper_* variable. They
are therefore dead catalogue entries: no deploy-side role exists to use
them and no image is built for them.
The result is that `check-drift.py --group all` reports zero
kolla_image_orphan drift (total "to act on" drops from 101 to 61). The
change also incidentally clears the two chrony image/tag entries that
kolla_orphan_config flagged in this file and removes the long-standing
`koll_rally_version` typo along with the dead rally block. No behaviour
changes -- these variables were never evaluated for any supported
release.
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Roger Luethi <luethi@osism.tech>
Remove six orphaned enable flags from all/003-kolla-overlays.yml: enable_karbor, enable_qinling, enable_searchlight and their enable_horizon_karbor / enable_horizon_qinling / enable_horizon_searchlight horizon toggles. Karbor, Qinling and Searchlight are retired OpenStack projects that upstream kolla-ansible removed in 2020 (Karbor 25b9de91a 2020-12-17, Qinling dafde93fe and Searchlight c7386a816 both 2020-11-28), well before the oldest OSISM-supported release. The drift check kolla_enablement_orphan reports these flags as orphaned. They were all set to "no" and have no live consumer anywhere in OSISM (the only other references are dead karbor_*/searchlight_* entries in testbed's auto-generated secrets superset), so removing them changes no behaviour. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove dead kolla
group_varsfor services upstream kolla-ansible retired wellbefore OSISM's oldest supported release (2024.1) — never evaluated, pure clutter.
all/002-images-kolla.yml— 11 orphaned image-catalogue blocks (monasca + allsub-images, rally, vmtp, kibana, zookeeper, elasticsearch/curator, kafka, storm,
panko, chrony, qdrouterd); 38
<svc>_image/<svc>_tagvars. Also drops thelong-standing
koll_rally_versiontypo.all/003-kolla-overlays.yml— 6 orphaned enable flags (enable_karbor,enable_qinling,enable_searchlight+ theirenable_horizon_*toggles).Each service was retired upstream before 2024.1 (verified against kolla-ansible git
history; dates in the commit messages), none is OSISM-built, and none has a live
consumer — a no-op on every supported release.
Clears the
kolla_image_orphan/kolla_enablement_orphandrift findings for thesevars. Independent of the group_vars mirror PR (disjoint files).
Related