OSAC-3364: Register new osac mono-repo in Terraform - #148
Merged
eliorerz merged 1 commit intoJul 29, 2026
Conversation
Adds the osac repo (OSAC-1732 mono-repo consolidation target) as a proper Terraform-managed resource before it's created, so it gets correct team access and branch protection from day one instead of being created ad-hoc and drifting on the next scheduled apply. allow_squash_merge is disabled to enforce the migration's git-history preservation constraint at the GitHub level. required_status_checks is left empty until OSAC-1734 builds the mono-repo's CI.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a Terraform module configuring the public ChangesOSAC repository setup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osacrepo (OSAC-1732 mono-repo consolidation target) as a proper Terraform-managed resource, before it's created on GitHuballow_squash_mergeto enforce the migration's git-history preservation constraint at the platform level (subtree-merge history/blame must survive ongoing PRs, which squash-merging would collapse)required_status_checksempty for now — will be added once OSAC-1734 builds the mono-repo's actual CIWhy
OSAC-1732 consolidates fulfillment-service, osac-operator, osac-aap, and osac-installer into a new
osacrepo. Creating it via the GitHub UI directly (rather than through this Terraform) would mean it's not managed the same way as every other org repo, and the scheduledapply.yaml(every 4h) would have no record of it.Test plan
tofu fmt -checkcleantofu validatepasses (only pre-existing deprecation warnings unrelated to this change)osacrepo gets created on the nexttofu applyTracking: OSAC-1732, OSAC-3364
Summary by CodeRabbit
osacrepository with configured team permissions and access controls.