OSAC-1675: Harden haproxy concurrency safety - #22
Open
eliorerz wants to merge 1 commit into
Open
Conversation
- Add _reload_haproxy() that recovers from stopped haproxy by falling back to systemctl restart when reload fails or service is inactive - Add _write_haproxy_cfg() that validates config with haproxy -c before applying, creates backup, and uses atomic write-then-rename - Make boot rollback resilient: wrap each cleanup step in try/except so one failure (e.g. haproxy down) doesn't abort remaining cleanup - Add cleanup-haproxy subcommand that finds orphaned haproxy entries (clone IDs with no matching VM) and removes them - Add tests for all new functionality (129 tests pass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_reload_haproxy()that recovers from stopped haproxy by falling back tosystemctl restartwhenreloadfails or service is inactive. Prevents cascading boot failures when haproxy is down._write_haproxy_cfg()that validates config withhaproxy -cbefore applying, creates a backup, and uses atomic write-then-rename to prevent corruption on SIGKILL.cleanup-haproxysubcommand that finds orphaned haproxy entries (clone IDs with no matching VM) and removes them along with stale DNS entries.Risk matrix addressed
_reload_haproxy()+ resilient rollbackhaproxy -c -fcheck in_write_haproxy_cfg()cleanup-haproxysubcommandmvTest plan
cluster-tool boot, confirm it auto-recoverscleanup-haproxy, confirm entries removed