Deprecate fields and clean up validation#593
Merged
Merged
Conversation
jroman-ak
force-pushed
the
clean-hazard-data-request
branch
from
ca4b878 to
82eae94
Compare
Signed-off-by: Juan Roman <jroman@arfimaconsulting.com>
jroman-ak
force-pushed
the
clean-hazard-data-request
branch
from
82eae94 to
031e1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HazardDataResponseItem, we renamed the fields event_type -> hazard_type and model -> indicator_id for clarity. We maintain backward compatibility by exposing the old fields as deprecated computed fields.
We also cleaned up hazard type validation in hazard data requests by removing the dependency on a hazard-name enum and validating against hazard classes instead (single source of truth).
Co-authored-by: Martxel Aranzadi Olazabal maranzadi@arfima.com
Co-authored-by: Yulian Lyubomirov Cenov ycenov@arfima.com
Signed-off-by: Juan Román Roche jroman@arfimaconsulting.com