Fix Slack bot_message event handling - #3
Draft
rapythe-cmyk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subtype=bot_messagethrough the Socket Mode filter.bot_idorbot_message, notuser.startswith("U").Why
Previously, the Socket Mode listener ignored all messages with a subtype. Slack bot messages commonly arrive as
subtype=bot_message, so dialog-channel bot-to-bot discussion mode could drop those events beforehandle_message()saw them.The old
is_other_botlogic also treated non-target human users with U-prefixed Slack IDs as other bots. The new helper keeps normal human users from being misclassified while still ignoring the daemon’s own bot messages.Checks
python3 -m unittest tests/test_slack_jipsa_event_filter.pypython3 -m py_compile templates/scripts/slack-jipsa/daemon.pypython3 -m py_compile templates/hooks/append_turn_raw.py templates/lib/notion.py templates/lib/slack_mrkdwn.py templates/lib/md_to_notion.pypython3 templates/lib/slack_mrkdwn.pygit diff --checkNote: py_compile was run with
PYTHONPYCACHEPREFIX=/private/tmp/agent-bootstrap-pycacheon this sandboxed macOS environment so bytecode cache writes stayed inside an allowed temp directory.