Add perspective projection, ability to hotswap between orthographic and perspective#89
Open
Nomagno wants to merge 2 commits into
Open
Add perspective projection, ability to hotswap between orthographic and perspective#89Nomagno wants to merge 2 commits into
Nomagno wants to merge 2 commits into
Conversation
|
nice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Ctrl + Alt + O -> Regular orthographic view
Ctrl + Alt + P -> New perspective view ('videogame camera' style)
Basically, both cameras are created at startup, but only the requested one is activated in Bevy. Not sure if this might suppose a performance penalty. I am also not an expert in Rust nor Bevy, so sorry if something's improvable 😅. I also refactored a bunch of
matchstatements into comparisons againstis_3d()where I thought it might be reasonable, since 3 long enum values per arm seemed silly once I added the newPersp3dmode (I can revert this if needed).I can make an issue if needed to discuss this further, just thought it was worth making a PR over since I had already implemented it. Demo video attached with the fixes from my other PR (for demo purposes since it uses the animation system).
persp_demo_compressed.mp4