Skip to content

adaptived: Add support for sharing data between causes and effects#52

Merged
drakenclimber merged 2 commits into
oracle:masterfrom
drakenclimber:shared-data
Jul 30, 2025
Merged

adaptived: Add support for sharing data between causes and effects#52
drakenclimber merged 2 commits into
oracle:masterfrom
drakenclimber:shared-data

Conversation

@drakenclimber

Copy link
Copy Markdown
Member

Add support for sharing data between a cause and the effect(s) that are
in the same rule. It is intended to share data unidirectionally from
the cause to the effect(s), but by using the persist flag, data can also
be shared from the effect(s) to the cause. (The persist flag can also
be used by the cause to retain data across adaptived_loop() loops.)

Sharing data in any direction makes tight coupling between causes and
effects. Use caution when sharing data, and clearly document data
sharing expectations.

@drakenclimber drakenclimber added this to the Adaptived v1.1.0 milestone Jul 17, 2025
@drakenclimber drakenclimber requested a review from sidkumar99 July 17, 2025 20:10
@drakenclimber drakenclimber self-assigned this Jul 17, 2025
@drakenclimber drakenclimber added the enhancement New feature or request label Jul 17, 2025
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 17, 2025
@drakenclimber

Copy link
Copy Markdown
Member Author

Code coverage on shared_data.c is 98.96%. I couldn't get coverage on the -ENOMEM line :).

https://coveralls.io/builds/74677750/source?filename=adaptived%2Fsrc%2Fshared_data.c

@sidkumar99 sidkumar99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Sidhartha Kumar sidhartha.kumar@oracle.com

@sidkumar99 sidkumar99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Sidhartha Kumar sidhartha.kumar@oracle.com

@drakenclimber drakenclimber force-pushed the shared-data branch 2 times, most recently from a35a39c to 45b4510 Compare July 22, 2025 22:52
@sidkumar99

Copy link
Copy Markdown

Reviewed-by: Sidhartha Kumar sidhartha.kumar@oracle.com

Cgroup v1 (Ubuntu 20) boxes have been retired in Github Actions.  Delete
all Github Actions jobs that require these machines

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Add support for sharing data between a cause and the effect(s) that are
in the same rule.  It is intended to share data unidirectionally from
the cause to the effect(s), but by using the persist flag, data can also
be shared from the effect(s) to the cause.  (The persist flag can also
be used by the cause to retain data across adaptived_loop() loops.)

Sharing data in any direction makes tight coupling between causes and
effects.  Use caution when sharing data, and clearly document data
sharing expectations.

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
@drakenclimber drakenclimber merged commit b9d222c into oracle:master Jul 30, 2025
6 checks passed
@drakenclimber drakenclimber deleted the shared-data branch July 30, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants