Repository navigation
[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #669
Merged
Muzahidul Islam (muzahidul-opti) merged 4 commits intoOct 28, 2026
Conversation
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: a87cc08 | Docs | View more details | Give us feedback! |
Alex Yong (alexjoeyyong)
requested review from
Matjaz Pirnovar (Mat001) and
esrakartalOpt
and removed request for
esrakartalOpt
October 27, 2026 17:32
Muzahidul Islam (muzahidul-opti)
approved these changes
Oct 28, 2026
Muzahidul Islam (muzahidul-opti)
left a comment
Contributor
There was a problem hiding this comment.
Intent: a local holdout hit now skips that rule only and evaluation continues. Hits are collected in order (global bypass, experiment rules, delivery rules) and each sends one holdout impression on the decide path.
I traced the flow against FSSDK-12958 and found nothing blocking: ordering, the CMAB-error discard of holdout hits, the unchanged "no rule serves" decision and the legacy no-event behavior all match the spec.
Muzahidul Islam (muzahidul-opti)
merged commit Oct 28, 2026
7103754
into
master
12 of 13 checks passed
Muzahidul Islam (muzahidul-opti)
deleted the
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
branch
October 28, 2026 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A local holdout hit used to return the holdout variation and stop evaluating the flag. Now it excludes the user from that rule only: the hit is recorded, the rule is skipped, and evaluation continues with the next experiment or delivery rule, so the user can still be served by a later rule.
Changes
Jira Ticket
FSSDK-12958