Skip to content

[AI-FSSDK] [FSSDK-12958] Continue rule evaluation after local holdout hit - #669

Merged
Muzahidul Islam (muzahidul-opti) merged 4 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix
Oct 28, 2026
Merged

Muzahidul Islam (muzahidul-opti) merged 4 commits into
masterfrom
ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix

Conversation

@alexjoeyyong

@alexjoeyyong Alex Yong (alexjoeyyong) commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A local holdout hit used to return the holdout variation and stop evaluating the flag. Now it excludes the user from that rule only: the hit is recorded, the rule is skipped, and evaluation continues with the next experiment or delivery rule, so the user can still be served by a later rule.

Changes

  • Local holdout hits on experiment and delivery rules skip that rule and continue to the next rule, with no jump to "Everyone Else"
  • Each local holdout hit sends one holdout impression in the existing format, regardless of sendFlagDecisions; disableDecisionEvent suppresses them
  • Holdout hits are collected in a list on the internal feature decision; no public API changes
  • Legacy APIs skip a locally held-out rule without sending a holdout event
  • The final decision and its events are unchanged; global holdouts are unchanged

Jira Ticket

FSSDK-12958

@coveralls

Coveralls (coveralls) commented Oct 16, 2026 •

Copy link
Copy Markdown

Coverage Status

Coverage is 93.964% — ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix into master. No base build found for master.

@datadog-optimizely-experimentation

datadog-optimizely-experimentation Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Swift | unittests / unittests (27.0, iPhone Air, OptimizelySwiftSDK-iOS, iphonesimulator, iOS Simulator, iOS) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a87cc08 | Docs | View more details | Give us feedback!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent: a local holdout hit now skips that rule only and evaluation continues. Hits are collected in order (global bypass, experiment rules, delivery rules) and each sends one holdout impression on the decide path.

I traced the flow against FSSDK-12958 and found nothing blocking: ordering, the CMAB-error discard of holdout hits, the unchanged "no rule serves" decision and the legacy no-event behavior all match the spec.

@muzahidul-opti
Muzahidul Islam (muzahidul-opti) merged commit 7103754 into master Oct 28, 2026
12 of 13 checks passed
@muzahidul-opti
Muzahidul Islam (muzahidul-opti) deleted the ai/alexjoeyyong/FSSDK-12958-local-holdout-flow-fix branch October 28, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants