-
Notifications
You must be signed in to change notification settings - Fork 50
Skip nag_dfols tests when DFO-LS is not installed #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
janosg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Swayam-maurya, thanks a lot for the PR! yes, this is something we want. Could you change it to use @pytest.mark.skipif instead of using pytest.skip inside an if condition? This makes it more aligned with the rest of optimagic. You can find an example here:
| @pytest.mark.skipif( |
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
|
Thanks for the suggestion!.. |
janosg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is ready to merge. I'll investigate the failing docs build; It's unrelated to your changes!
|
Thanks a lot! Appreciate you looking into the docs build. |
|
Hi @janosg ...Thanks again for merging the PR. |
This PR skips the nag_dfols optimizer tests when the optional DFO-LS dependency
is not available.
Without this guard, pytest fails during test collection when DFO-LS is not
installed locally. The change makes the test suite robust to optional optimizer
dependencies, consistent with how other optimizers are handled.