Rework coupling model

[jgiret]

Hello Marco,

As discussed, please find my recent modifications on the GEMS wrapper for the toy problem.

[marcocisternino]

Hello JC, I saw some intervention on coupling.*pp files. You started your develpments from an old branch, reworkCouplingModel. You should start from newThermalDiffusivity and your modifications on coupling files should not be needed. Now we have: m_disciplineRadius, m_oldDisciplineRadius m_neutralRadius, m_oldNeutralRadius I store both old and new radius for scaling purpose, the scaling factor is new/old I store neutral mesh radii too, just for sake of completeness and in the case we want to change the way we treat radiation. Probably not, but just in case.. Can you rebase your branch on newThermalDiffusivity, please? By this way the merge of your branch should deal with python files only. Thanks, Marco Cisternino, PhD marco.cisternino@optimad.it

…

_______________________________ OPTIMAD Engineering srl Via Bligny 5, Torino, Italia. +3901119719782 www.optimad.it

________________________________________ Da: Jean-Christophe Giret <notifications@github.com> Inviato: lunedì 30 novembre 2020 14:54 A: optimad/madeleine Cc: Subscribed Oggetto: [optimad/madeleine] Rework coupling model (#6) Hello Marco, As discussed, please find my recent modifications on the GEMS wrapper for the toy problem.

________________________________ You can view, comment on, or merge this pull request online at: #6 Commit Summary * Create test for GEMS toy problem * Add test for disciplines, chain and MDA * Modification on coupling cpp and hpp files File Changes * A python-wrapper/build.sh<https://github.com/optimad/madeleine/pull/6/files#diff-3cfc59f2f57f1b7660bd911a140baa601ce5083410516a583bf563157ef432b2> (1) * A python-wrapper/env.sh<https://github.com/optimad/madeleine/pull/6/files#diff-892042179308da2146b39c429e3ab4a0d40a03a7286f922cd10b485e7b7f84b1> (2) * M python-wrapper/gems_wrapper.py<https://github.com/optimad/madeleine/pull/6/files#diff-b7b5de21a110d717a8e68adcb2740b07962fafc1fd7230fe6e04f7671ab6d35e> (135) * M python-wrapper/test_chain.py<https://github.com/optimad/madeleine/pull/6/files#diff-ff8b23427fd9b83860115125c48ee8a596dca38e4a89d310e4b126e9096901ef> (105) * M python-wrapper/test_gems_wrapper.py<https://github.com/optimad/madeleine/pull/6/files#diff-26945413caae6940beb0b8b533b0b203a6ee7322118bd0d1a10da04ef8fe8979> (48) * A python-wrapper/test_gems_wrapper_inner.py<https://github.com/optimad/madeleine/pull/6/files#diff-691d0f95d0c127d0649799c1a95db7d08be1e40a5295314642d2866fec575005> (57) * A python-wrapper/test_gems_wrapper_outer.py<https://github.com/optimad/madeleine/pull/6/files#diff-4a94a54eede63df5da55b9d3bc02d26e623595f250fbddd239876c82965de101> (56) * M python-wrapper/test_mda.py<https://github.com/optimad/madeleine/pull/6/files#diff-0f3d236a6a1a33d79bb29e0fc81de135b7eced80b53ca3c07176a68d7272f70b> (163) * A python-wrapper/test_toy_chain.py<https://github.com/optimad/madeleine/pull/6/files#diff-0b3c818761fbd7eb67b9a220ebe8436f1a3f1cef4d36698f6c35a700ba41bd29> (43) * M src/coupling.cpp<https://github.com/optimad/madeleine/pull/6/files#diff-3c3f1f486001b12ba9f2cf495355136d504abcf4a754d9350220ac1509fee4f0> (27) * M src/coupling.hpp<https://github.com/optimad/madeleine/pull/6/files#diff-3edfec08f788d1e19b5a182eea3830706d3f7002ecfcec2ab7e21dd4460e2521> (1) Patch Links: * https://github.com/optimad/madeleine/pull/6.patch * https://github.com/optimad/madeleine/pull/6.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#6>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSMIGB3WQEMGJMRRVC6YUTSSOP2PANCNFSM4UHTLPOA>.