Merged
Conversation
Bumps [rails](https://github.com/rails/rails) from 8.0.4 to 8.1.2. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v8.0.4...v8.1.2) --- updated-dependencies: - dependency-name: rails dependency-version: 8.1.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Rails 8.1 removed deprecated support for stripping leading brackets in parameter names (rails/rails#53471). Previously, a form field named `[custom_field_values][123]` was parsed as `{ "custom_field_values" => { "123" => "" } }`. In Rails 8.1, it is parsed as `{ "[custom_field_values]" => { "123" => "" } }`, making the custom field values invisible to `params.fetch(:custom_field_values, {})`. `custom_field_tag_for_bulk_edit` was called with an empty string as the `name` prefix (e.g. in the work package move form), producing field names like `[custom_field_values][42]` — starting with a leading bracket. This caused required custom field validation to be silently skipped during moves, allowing work packages to be moved without filling in required fields. The fix avoids the leading bracket by emitting `custom_field_values[42]` when no name prefix is given.
myabc
reviewed
Feb 11, 2026
|
|
||
| def custom_field_tag_for_bulk_edit(name, custom_field, project = nil) # rubocop:disable Metrics/AbcSize | ||
| field_name = "#{name}[custom_field_values][#{custom_field.id}]" | ||
| field_name = name.present? ? "#{name}[custom_field_values][#{custom_field.id}]" : "custom_field_values[#{custom_field.id}]" |
Contributor
There was a problem hiding this comment.
@ulferts FYI, Primer also has had various issues with generating fields with nested attributes/array types.
myabc
approved these changes
Feb 11, 2026
dombesz
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/71880
Bumps rails from 8.0.4 to 8.1.2.
Release notes
Sourced from rails's releases.
... (truncated)
Commits
d7c8ae6Preparing for 8.1.2 release695ac6dUpdate Gemfile.lock01263f1Merge pull request #56512 from byroot/remove-minitest-ci3ea2701CHANGELOG syncd3fe83fMerge pull request #56541 from rails/remove-system-test-from-default-ci-template5283514Merge pull request #56012 from jmalcic/restore-default-adc-for-gcs-iam-client53e82efMerge pull request #56534 from khasinski/fix-sqlite3-schema-dump-default-nild2509f8Allow backburner warning8c48fd1Merge pull request #56535 from eglitobias/8-1-stableadcfaceFix PostgreSQL schema_search_path after reconnect and resetDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)