Repository navigation
feat: stage migration with a COS and protected COD #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tmshort
wants to merge
6
commits into
main
Choose a base branch
from
migration-cos-cod-handoff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
050ec1f
feat: stage migration with a COS and protected COD
tmshort e379b85
test: clean up packed Secrets after collision checks
tmshort ac742e0
test: assert the staging revision enforces collision protection
tmshort 309beea
fix: complete initial COS adoption before protected COD rollout
tmshort e0b28b8
fix: allow bounded collision retries during revision handoff
tmshort 4c0d7b4
test: cover dry-run validation of both migration resources
tmshort File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor/non-blocking: could we make the corresponding change in
dryRunRecordtoo? That function still clearscosNamewhenUseClusterObjectDeploymentis true, soconvert --dry-run --output=jsonlomitscluster_object_set, even though this path now explicitly creates both the initial COS and the COD. The human preview here correctly lists both.Keeping
cosNameas<ce-name>-1and setting onlycodNameconditionally would make the structured preview match the new staging protocol. Please also cover both fields in COD mode:assertStructuredCheckAndPreviewcurrently accepts either one, so it misses this discrepancy. I reproduced it with a focused test: COS-only includes the initial COS, while COS+COD omits it.