Skip to content

chore: update operator-controller revision APIs - #100

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
migration-operator-controller-content-api
Nov 13, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
mainfrom
migration-operator-controller-content-api

Conversation

@tmshort

@tmshort tmshort commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Update the operator-controller Go dependency and migration E2E installation pin to commit dae9b613163a, keeping the API definitions and tested controller aligned.

The upstream COS and COD APIs now embed ClusterObjectSetContent. Update rollback test literals to construct that shared content explicitly. No production migration behavior changes are needed for this API update. Refresh the migration plan and E2E guide with the new pin.

Validation

  • make migration/test-unit
  • make lint
  • go test -tags=e2e ./test/e2e/migration -run '^$'
  • Fresh make migration/e2e-fixture-setup
  • make migration/test-e2e-cos-supersession migration/test-e2e-cod-rollback
  • make migration/test-e2e-fixture-matrix — all three operators passed

The temporary kind cluster was removed after testing.

Summary by CodeRabbit

  • Chores
    • Updated versions of supporting components used by migration workflows.
    • Migration setup and related guidance now reference a newer controller build.
    • These updates affect the underlying migration tooling and its version references; no new user-facing features or behavior changes are included.

Update the operator-controller dependency and E2E installation pin to dae9b613163a. Adapt rollback test literals to the embedded ClusterObjectSetContent type and refresh the migration documentation.

Validated migration unit tests, lint, E2E compilation, the focused handoff and rollback E2E tests, and the three-operator fixture matrix.

Signed-off-by: Todd Short <tshort@redhat.com>
@openshift-ci
openshift-ci Bot requested review from Leo6Leo and pedjak November 13, 2026 16:53
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The operator-controller dependency and migration commit references are updated. Rollback recovery test fixtures now nest phases under ClusterObjectSetContent.

Changes: Operator-controller version update

Layer / File(s) Summary
Update dependency and migration pins
go.mod, migration.mk, specs/20260821-migration-v0-to-v1/*
go.mod updates the operator-controller and three indirect dependency versions, and removes an indirect dependency. Migration setup and documentation use the newer operator-controller commit.
Update rollback recovery fixtures
migration/pkg/migration/rollback_recovery_test.go
The sibling-handoff and snapshot-ordering test fixtures place phases under ClusterObjectSetContent.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to e05f1

This updates the operator-controller dependency and migration test pins, and adapts rollback test fixtures to the new API shape. No production migration behavior changes, and no actionable merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title uses the conventional commit prefix 'chore:' and names an update to operator-controller revision APIs. The changeset updates the operator-controller Go dependency and migration E2E pin to co…
Description check Passed The description states the purpose, the dependency and E2E pin update, the rollback test literal changes, and the documentation refresh. It lists validation commands and their results. The template's …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses the conventional commit prefix 'chore:' and names an update to operator-controller revision APIs. The changeset updates the operator-controller Go dependency and migration E2E pin to commit dae9b613163a, and adapts rollback test literals to the embedded ClusterObjectSetContent API. The title refers to the main change, though it does not mention the test literal updates or the documentation refresh. It is specific enough for a reviewer scanning history.

Full details: Description check

Explanation

The description states the purpose, the dependency and E2E pin update, the rollback test literal changes, and the documentation refresh. It lists validation commands and their results. The template's Reviewer Checklist is not present in the description. Checklist items for API Go Documentation, unit and E2E tests, commit messages, and linked GitHub issues are not addressed. No linked issue is referenced. The description covers the summary section well, but the checklist portion of the template is missing.

Resolution

Add the Reviewer Checklist from the repository template to the description. Mark each item that applies. Link the related GitHub issue, if one exists. Confirm that API Go documentation and commit messages meet the repository standard.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: ab4dc7cf-dc1d-4553-b42f-b7799b9aa666
Commits

Reviewing files that changed from the base of the PR and between 85fefdf and e05f1b5.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 5

  • go.mod
  • migration.mk
  • migration/pkg/migration/rollback_recovery_test.go
  • specs/20260821-migration-v0-to-v1/e2e.md
  • specs/20260821-migration-v0-to-v1/plan.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@tmshort

tmshort commented Nov 13, 2026

Copy link
Copy Markdown
Member Author

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2026

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2026
@openshift-ci

openshift-ci Bot commented Nov 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 483f71a into main Nov 13, 2026
14 checks passed
@tmshort
tmshort deleted the migration-operator-controller-content-api branch November 13, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants