Skip to content

add flavours to title#305

Open
elfkuzco wants to merge 2 commits into
title-metadatafrom
title-flavours
Open

add flavours to title#305
elfkuzco wants to merge 2 commits into
title-metadatafrom
title-flavours

Conversation

@elfkuzco
Copy link
Copy Markdown
Contributor

Rationale

This PR adds flavours column to titles. When notifications are being processed and the new book's flavour is not in the list of title flavours, the book is moved to staging irrespective of the title's maturity. Consequently, books with flavour mismatch cannot be manually moved from staging to prod

Screenshot_20260527_232835 Screenshot_20260527_232821 Screenshot_20260527_232333

This closes #294

@elfkuzco elfkuzco self-assigned this May 27, 2026
@elfkuzco elfkuzco requested a review from benoit74 May 27, 2026 22:43
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.24%. Comparing base (8c6471d) to head (22a343d).
⚠️ Report is 2 commits behind head on title-metadata.

Files with missing lines Patch % Lines
backend/src/cms_backend/db/title.py 33.33% 1 Missing and 1 partial ⚠️
backend/src/cms_backend/api/main.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           title-metadata     #305   +/-   ##
===============================================
  Coverage           82.24%   82.24%           
===============================================
  Files                  58       58           
  Lines                2721     2738   +17     
  Branches              277      280    +3     
===============================================
+ Hits                 2238     2252   +14     
- Misses                410      412    +2     
- Partials               73       74    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes + we need a maintenance script to populate title flavours from existing book flavours.

Comment thread frontend/src/views/BookView.vue Outdated
Comment thread frontend/src/views/BookView.vue Outdated
Comment thread frontend/src/views/BookView.vue Outdated
Comment thread frontend/src/views/TitleView.vue Outdated
Comment thread frontend/src/components/TitleForm.vue Outdated
Comment thread frontend/src/components/BookTable.vue
Comment thread backend/src/cms_backend/db/book.py Outdated
@elfkuzco
Copy link
Copy Markdown
Contributor Author

Few minor changes + we need a maintenance script to populate title flavours from existing book flavours.

Will the title flavours be made of the set of all flavours it's book has? On local, I notice there are flavours like _maxi and maxi. I figured the first might be a mistake.

@elfkuzco
Copy link
Copy Markdown
Contributor Author

Added a maint-script that doesn't just set the title flavours from the set of it's book's flavours. It also fixes those books too whose flavours start with _. So, _maxi becomes maxi , etc

@elfkuzco elfkuzco requested a review from benoit74 May 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants