[tests] Added multi-tentant tests for shared objects by pandafy · Pull Request #1024 · openwisp/openwisp-controller

pandafy · 2025-05-09T16:15:30Z

Checklist

I have read the OpenWISP Contributing Guidelines.
I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.

Blockers

[feature] Allowed read only access of shared objects to non-superusers #238 openwisp-users#444

pandafy · 2025-05-27T13:59:10Z

.github/workflows/ci.yml

        pip install -U pip wheel setuptools
        pip install -U -r requirements-test.txt
        pip install -U -e .
+        pip install -UI "openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/issues/238-view-shared-objects"


TODO: Remove before merging

nemesifier

I tried accessing shared objects via REST API and this is what I found:

Ok:
- Device, Vpn, Credential, IPAM subnet
Not ok:
- Template: 403
- Ca: 403
- Cert: 403
- Ip address list of a shared subnet, I get 404, eg: /api/v1/ipam/subnet/{pkl}/ip-address/

When using the admin it becomes evident that we'll need to work on #848 next.

openwisp_controller/connection/tests/test_api.py

pandafy · 2025-06-04T14:54:22Z

.github/workflows/ci.yml

        pip install -U pip wheel setuptools
        pip install -U -r requirements-test.txt
        pip install -U -e .
+        pip install -UI "openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/issues/238-view-shared-objects" "cryptography~=43.0.3"


Upgrading openwisp-users was installing the latest version of cryptography which is incompatible with django-x509. Thus, pinning the dependency here fixed the CI build.

coveralls · 2025-06-04T14:55:02Z

coverage: 98.793% (+0.05%) from 98.746%
when pulling 8c9efc8 on updated-multitenant-tests
into 4ea68be on master.

Added migrations to add "view" permissions

nemesifier · 2026-01-20T17:37:45Z

@coderabbitai review

coderabbitai · 2026-01-20T17:37:52Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-01-20T17:37:55Z

Warning

Rate limit exceeded

@nemesifier has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 28 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1ee8c25 and 8c9efc8.

📒 Files selected for processing (16)

.github/workflows/ci.yml
openwisp_controller/config/migrations/0061_update_groups_permissions.py
openwisp_controller/config/migrations/__init__.py
openwisp_controller/config/tests/test_admin.py
openwisp_controller/config/tests/test_api.py
openwisp_controller/connection/base/models.py
openwisp_controller/connection/tests/test_admin.py
openwisp_controller/connection/tests/test_api.py
openwisp_controller/geo/migrations/0004_update_groups_permissions.py
openwisp_controller/geo/migrations/__init__.py
openwisp_controller/pki/api/serializers.py
openwisp_controller/pki/base/models.py
openwisp_controller/pki/migrations/0012_update_group_permissions.py
openwisp_controller/pki/migrations/__init__.py
openwisp_controller/pki/tests/test_admin.py
openwisp_controller/pki/tests/test_api.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

The tasks._is_update_in_progress function will exclude the current task from the check. Fixes #1024 Co-authored-by: Piyush Bafna <130243298+piyushdev04@users.noreply.github.com>

pandafy added this to OpenWISP Contributor's Board May 9, 2025

github-project-automation bot moved this to To do (general) in OpenWISP Contributor's Board May 9, 2025

pandafy moved this from To do (general) to In progress in OpenWISP Contributor's Board May 9, 2025

pandafy force-pushed the updated-multitenant-tests branch 2 times, most recently from 3bcabf0 to 2d4afea Compare May 22, 2025 07:42

nemesifier assigned pandafy May 26, 2025

pandafy commented May 27, 2025

View reviewed changes

nemesifier requested changes May 27, 2025

View reviewed changes

openwisp_controller/connection/tests/test_api.py Show resolved Hide resolved

nemesifier added the enhancement label May 27, 2025

nemesifier mentioned this pull request May 27, 2025

[feature] Allowed read only access of shared objects to non-superusers #238 openwisp/openwisp-users#444

Open

4 tasks

pandafy force-pushed the updated-multitenant-tests branch from 2d4afea to 73bc66f Compare May 28, 2025 11:38

pandafy force-pushed the updated-multitenant-tests branch 2 times, most recently from 46c0821 to c46269f Compare June 4, 2025 14:41

pandafy commented Jun 4, 2025

View reviewed changes

nemesifier force-pushed the master branch from 10c0cde to 4ea68be Compare July 3, 2025 22:08

pandafy added 8 commits July 4, 2025 19:27

[tests] Added multi-tentant tests for shared objects

a2c2657

[temp] Upgraded openwisp-users

a77e765

[tests] Added tests for multi-tenant admin

a8616ab

[temp] Install openwisp-users from branch

66a5d69

[tests] Added tests for multi-tenant admin

30470ca

[qa] Formatted code

53330f0

[req-changes] Added test for shared Credentials

defb0cb

Added migrations to add "view" permissions

[ci] Pinned django-x509

2a4a863

pandafy force-pushed the updated-multitenant-tests branch from c46269f to 2a4a863 Compare July 4, 2025 13:57

pandafy added 2 commits July 8, 2025 23:12

[change] Hide senstive fields on shared objects from non-superuser

c75c6b5

[change] Hide sensitive fields for shared objects in the API response

8c9efc8

nemesifier added this to 25.09 Release Sep 3, 2025

nemesifier moved this to In progress in 25.09 Release Sep 3, 2025

nemesifier moved this from In progress to Backlog in 25.09 Release Sep 12, 2025

nemesifier added this to 26.05 Release Jan 20, 2026

github-project-automation bot moved this to Backlog in 26.05 Release Jan 20, 2026

github-project-automation bot moved this from Backlog to In progress in 26.05 Release Jan 20, 2026

nemesifier removed this from 25.09 Release Jan 20, 2026

pandafy mentioned this pull request Mar 17, 2026

[fix] Fixed update_config duplicate task detection #1204 #1292

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[tests] Added multi-tentant tests for shared objects#1024

[tests] Added multi-tentant tests for shared objects#1024
pandafy wants to merge 10 commits intomasterfrom
updated-multitenant-tests

pandafy commented May 9, 2025 •

edited

Loading

Uh oh!

pandafy May 27, 2025

Uh oh!

nemesifier left a comment

Uh oh!

Uh oh!

pandafy Jun 4, 2025

Uh oh!

coveralls commented Jun 4, 2025 •

edited

Loading

Uh oh!

nemesifier commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026

Rate limit exceeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pandafy commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

pandafy May 27, 2025

Choose a reason for hiding this comment

Uh oh!

nemesifier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pandafy Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

coveralls commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nemesifier commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026

Rate limit exceeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pandafy commented May 9, 2025 •

edited

Loading

coveralls commented Jun 4, 2025 •

edited

Loading